Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update node.js version from 20 to 22.7.0 #8313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update node.js version from 20 to 22.7.0 #8313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.11.0
22.4.1
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@
"@types/jest": "29.5.13",
"@types/lodash": "4.17.10",
"@types/mongodb": "4.0.7",
"@types/node": "20.16.11",
"@types/pg": "8.11.10",
"@types/node": "22.4.1",
"@types/request": "2.48.12",
"eslint": "8.57.1",
"eslint-plugin-header": "3.1.1",
Expand Down
9 changes: 4 additions & 5 deletions src/deploy/NVA_build/NooBaa.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,10 @@ ENV PORT=8080
ENV SSL_PORT=8443
ENV ENDPOINT_PORT=6001
ENV ENDPOINT_SSL_PORT=6443
ENV WEB_NODE_OPTIONS=''
ENV BG_NODE_OPTIONS=''
ENV HOSTED_AGENTS_NODE_OPTIONS=''
ENV ENDPOINT_NODE_OPTIONS=''

ENV WEB_NODE_OPTIONS='--no-experimental-websocket'
ENV BG_NODE_OPTIONS='--no-experimental-websocket'
ENV HOSTED_AGENTS_NODE_OPTIONS='--no-experimental-websocket'
ENV ENDPOINT_NODE_OPTIONS='--no-experimental-websocket'
##############################################################
# Layers:
# Title: Installing dependencies
Expand Down
2 changes: 2 additions & 0 deletions src/deploy/NVA_build/noobaa_init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,15 @@ init_noobaa_agent() {

cd /root/node_modules/noobaa-core/
prepare_agent_conf
# run_internal_process node --no-experimental-websocket --unhandled-rejections=warn ./src/agent/agent_cli
run_internal_process node --unhandled-rejections=warn ./src/agent/agent_cli
}

migrate_dbs() {
fix_non_root_user

cd /root/node_modules/noobaa-core/
# /usr/local/bin/node --no-experimental-websocket --unhandled-rejections=warn src/upgrade/migration_to_postgres.js
/usr/local/bin/node --unhandled-rejections=warn src/upgrade/migration_to_postgres.js
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/unit_tests/run_npm_test_on_test_container.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ do
command=${*}
command_array=(${command})
shift ${#command_array[@]};;
-s|--single) command="./node_modules/mocha/bin/mocha.js src/test/unit_tests/${2}"
-s|--single) command="./node_modules/mocha/bin/mocha.js src/test/unit_tests/${2} --no-exit"
shift 2;;
*) usage;;
esac
Expand Down
3 changes: 3 additions & 0 deletions src/test/unit_tests/test_nb_native_fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@ mocha.describe('nb_native fs', async function() {
await tmpfile.replacexattr(DEFAULT_FS_CONFIG, set_options, clear_prefix);
const xattr_res2 = (await tmpfile.stat(DEFAULT_FS_CONFIG)).xattr;
await tmpfile.close(DEFAULT_FS_CONFIG);
console.log(Object.keys(xattr_res1));
console.log(Object.keys(xattr_res2));
console.log("Testing=====================");
assert.deepEqual(xattr_obj, xattr_res1);
assert.deepEqual({ 'user.key2': 'value2', 'user.key3': 'value3' }, xattr_res2);

Expand Down
Loading