-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC | Accounts ID cache addition #8304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
reviewed
Aug 26, 2024
@romayalon The main open points I have in this PR are:
|
romayalon
force-pushed
the
romy-accounts-id-cache
branch
from
August 29, 2024 08:00
60e1e41
to
457114d
Compare
@shirady @guymguym I suggest discussing it next week
|
romayalon
force-pushed
the
romy-accounts-id-cache
branch
from
August 29, 2024 10:34
457114d
to
7485cfa
Compare
romayalon
force-pushed
the
romy-accounts-id-cache
branch
from
October 15, 2024 07:14
7485cfa
to
13afff5
Compare
shirady
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments
romayalon
force-pushed
the
romy-accounts-id-cache
branch
from
October 15, 2024 08:22
5463713
to
a7552dc
Compare
shirady
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
romayalon
force-pushed
the
romy-accounts-id-cache
branch
from
October 15, 2024 11:57
0903aee
to
8d80287
Compare
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-accounts-id-cache
branch
from
October 15, 2024 14:59
8d80287
to
a57ad85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: