NC | Config Dir Restructure

[romayalon]

Explain the changes

This PR is based on @alphaprinz #8167 PR.

1. Added to the new structure the following paths -

identities/
     {account_id}/account.json
     
accounts_by_name/
     {account_name}.symlink -> ../identities/{account_id}/account.json

3. Re-implemented create/update/delete account in configFS to adhere the new config dir structure.
4. Backwards compatibility -

• Added backward compatibility to the following accounts getter functions -
• get_account_by_name()
• is_account_exists({name: string})
• list_accounts()

5. Updated getter callers to these functions to have { fallback:true } options.
6. Converted tests to use config_fs.
7. Added backward compatibility tests.

Issues: Fixed #xxx / Gap #xxx

1. Add structure tests.
2. Add list account backward compatibility tests after we agree on the expected result.
3. Update Docs.
4. Gap - When starting to use the new mapping

Testing Instructions:

1. sudo npx jest --testRegex=jest_tests/test_config_fs_backward_compatibility.test.js

• Doc added/updated
• Tests added

[shirady]

Adding comments on the file config_fs

[shirady]

Adding additional comments.

[shirady]

@romayalon, a question - after changing the file name to identity.json I thought we would also have identity_type in the JSONs, did I miss something?

[romayalon]

@shirady I understood from @guymguym suggestion that we won't add it to account JSON, and when it's missing it's saying the identity is account, @guymguym did I understand correctly?

[shirady]

@shirady I understood from @guymguym suggestion that we won't add it to account JSON, and when it's missing it's saying the identity is account, @guymguym did I understand correctly?

@romayalon I understand that we need to add it, but for the existing config files we will not have to add it because a missing property there means account.
Anyway, it is something that we will add when we will expand the identities (role, policy, etc.).

[shirady]

Why doesn't it include the silent_if_missing condition? (like we have in folder_delete).

[romayalon]

as we discussed, we always want on this case to not fail if the config file is missing

[shirady]

LGTM

[shirady]

@romayalon
2 things that we might want to discuss in the future:

1. Do we want to add a property the accounts schema that will define the identity type for the account (link) - we would probably need it when we will plan to add additional property.
2. In get_identity_by_id adding manually the error code ENOENT (link) - we need to examine it during the use if it creates somehow any confusion.