Merged
Conversation
Romanelaf
reviewed
Oct 27, 2025
src/probe/freeze_detect.rs
Outdated
| keys: vec
There was a problem hiding this comment.
pas besoin de récupérer freeze_duration si tu l'utilises pas
src/probe/freeze_detect.rs
Outdated
| let mut freezedetect_params: HashMap<String, ParameterValue> = HashMap::new(); | ||
| if let Some(duration) = params.get("duration") { | ||
| if let Some(min_duration) = duration.min { | ||
| let min = (min_duration as f64 - 1.0) * 1000.0; |
Collaborator
There was a problem hiding this comment.
tu as vraiment besoin du - 1.0 ici ?
Contributor
Author
There was a problem hiding this comment.
non pas besoin en effet et je peux enlever le check qu'on refait après aussi
Romanelaf
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nomalab/nomalab#5474