Fix trailing_newline issue in Builder::build #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Buffer::has_trailing_newline` transitively depends on `len_left` which depends on `left_summary` being up to date. However, `Builder::finish` was calling them in the reverse order.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I found a little issue where building a rope using the builder would result in different line lengths compared to constructing the Rope directly (using
Rope::from).Buffer::has_trailing_newlinetransitively depends onlen_leftwhich depends onleft_summarybeing up to date. However,Builder::finishwas calling them in the reverse order so this wouldn't work in some cases.Since
has_trailing_newlineis now false instead of true, the line length is too great by 1.