Skip to content

Testing artifact upload step #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noisy wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Testing artifact upload step #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf53dc2
🚀 chore(cypress.yml): add artifact upload step
noisy Apr 16, 2023
d9c55f6
🚀 chore(cypress.yml): move upload artifacts step to a separate job na…
noisy Apr 16, 2023
ef0ddd5
🐛 fix(cypress.yml): add needs parameter to upload job to ensure it ru…
noisy Apr 16, 2023
259ffad
🚀 chore(cypress.yml): add upload of cypress artifacts on E2E and Comp…
noisy Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ jobs:
# re-enable PR comment bot
COMMIT_INFO_SHA: ${{github.event.pull_request.head.sha}}

- name: E2E tests - Upload test artifacts
if: ${{ failure() }}
uses: actions/upload-artifact@v3
with:
name: cypress-artifacts
path: |
cypress/screenshots/
cypress/videos/

- name: Components tests
uses: cypress-io/github-action@v5.6.1
with:
Expand All @@ -60,3 +69,12 @@ jobs:
COMMIT_INFO_MESSAGE: ${{github.event.pull_request.title}}
# re-enable PR comment bot
COMMIT_INFO_SHA: ${{github.event.pull_request.head.sha}}

- name: Components tests - Upload test artifacts
if: ${{ failure() }}
uses: actions/upload-artifact@v3
with:
name: cypress-artifacts
path: |
cypress/screenshots/
cypress/videos/
4 changes: 4 additions & 0 deletions cypress.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ export const config: Parameters<typeof defineConfig>[0] = {
setupNodeEvents,
baseUrl: "http://localhost:5050",
specPattern: "cypress/e2e/**/*.cy.ts",
video: true,
videosFolder: "cypress/videos",
screenshotOnRunFailure: true,
screenshotsFolder: "cypress/screenshots",
},
component: {
devServer: {
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/topNavigation.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe("Top navigation test", () => {
["Projects", "Talks", "Blog"].forEach((page) => {
it(`Should go to ${page} and back`, () => {
cy.get(`@${page.toLowerCase()}`).click();
cy.location("pathname").should("eq", `/${page.toLowerCase()}`);
cy.location("pathname").should("eq", `/reksio-${page.toLowerCase()}`);
cy.get("h2").invoke("text").should("include", page);
goBackToHome();
});
Expand Down