Replace deprecated jQuery event shorthand #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I couldn't look at this earlier. Looks good, but the enclosing Would you be kind enough to amend your PR? I can't do it myself as I'm without access to a computer for almost two more weeks... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/jquery/jquery-migrate/blob/master/warnings.md
The current use of blur() and focus() trigger warnings for those of us running jquery-migrate
I noticed there is one other call to blur() and one other call to focus() but I believe those are to the vanilla JS versions of blur() and focus() not the jQuery versions so I don't think they should be changed.
FWIW, this fork fixes the jQuery Migrate warnings for me.