Skip to content

Conversation

Copy link

Copilot AI commented Jan 7, 2026

Addressed review feedback on PR #46 regarding Ring.Reset() timing in FrameRateConverter node.

The current implementation is correct: Ring.Reset(EffectiveCapacity) is called in OnPathStart() (line 96), which executes after SendPathRestart() completes. This ensures the ring buffer is reset after the path restart, not before.

void OnRatioPinValueChanged(fb::vec2u const* newRatio, ...) {
    // ... validation ...
    EffectiveCapacity = requiredEffectiveCapacity;
    SendPathRestart(NodeId);  // Reset happens after this completes
}

void OnPathStart() override {
    Ring.Reset(EffectiveCapacity);  // Reset occurs here, after path restart
    // ...
}

No code changes required.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Jan 7, 2026
Copilot AI changed the title [WIP] Address feedback on Frame Rate Converter reset timing Confirm Ring.Reset() timing is correct after path restart Jan 7, 2026
Copilot AI requested a review from shamilatesoglu January 7, 2026 14:13
Base automatically changed from wip-frame-rate-converter to dev January 8, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants