Confirm Ring.Reset() timing is correct after path restart #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review feedback on PR #46 regarding Ring.Reset() timing in FrameRateConverter node.
The current implementation is correct:
Ring.Reset(EffectiveCapacity)is called inOnPathStart()(line 96), which executes afterSendPathRestart()completes. This ensures the ring buffer is reset after the path restart, not before.No code changes required.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.