Clarify strncpy usage in FrameRateConverter error handling #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Address feedback on frame rate converter node implementation
Clarify strncpy usage in FrameRateConverter error handling
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review feedback questioning the correctness of a
strncpycall in the FrameRateConverter implementation.Resolution
No code changes required. The existing implementation is correct:
The string is 41 characters, so with null terminator it's exactly 42 bytes. The bot reviewer miscounted the string length as 43 bytes.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.