Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,25 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added
- `TableStyle.cornerRadius` rounds the rendered table wrapper's corners:
interior painting (header fill, separator rules) clips to the rounded
shape and the outer border rule strokes along the rounded path, staying
crisp at the corners. `0` (the default) keeps the historical
square-cornered rendering exactly.
- Table theming slots: `MarkdownEditorTheme.tableHeaderBackground` fills the
rendered header row (nil = the historical mutedText at 8% alpha) and
`MarkdownEditorTheme.tableRule` strokes the outer border and internal
rules (nil = mutedText at 50% alpha). Both participate in the table image
cache key.
- Custom heading typeface and color: `HeadingStyle.fontName` renders headings
in a specific PostScript face (honored exactly, so the chosen weight is
respected; an unresolvable name falls back to the stock bold base font),
and `MarkdownEditorTheme.headingText` colors heading text independently of
`bodyText` — the `#` glyphs stay on `headingMarker`, and inline constructs
inside a heading keep their own ink (both opt-in; the defaults are
unchanged).

## [0.11.0] - 2026-07-31

### Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public struct MarkdownEditorConfiguration: Sendable {
public var codeBlock: CodeBlockStyle
public var inlineCode: InlineCodeStyle
public var lists: ListStyle
public var table: TableStyle
public var taskCheckbox: TaskCheckboxStyle
public var headings: HeadingStyle
public var imageEmbed: ImageEmbedStyle
Expand Down Expand Up @@ -92,6 +93,7 @@ public struct MarkdownEditorConfiguration: Sendable {
codeBlock: CodeBlockStyle = .default,
inlineCode: InlineCodeStyle = .default,
lists: ListStyle = .default,
table: TableStyle = .default,
taskCheckbox: TaskCheckboxStyle = .default,
headings: HeadingStyle = .default,
imageEmbed: ImageEmbedStyle = .default,
Expand All @@ -118,6 +120,7 @@ public struct MarkdownEditorConfiguration: Sendable {
self.codeBlock = codeBlock
self.inlineCode = inlineCode
self.lists = lists
self.table = table
self.taskCheckbox = taskCheckbox
self.headings = headings
self.imageEmbed = imageEmbed
Expand Down Expand Up @@ -349,15 +352,30 @@ public struct TaskCheckboxStyle: Sendable {
/// Per-level heading metrics. Defaults follow the historical Nodes ratios,
/// which are loosely based on browser default heading sizes.
public struct HeadingStyle: Sendable {
/// PostScript name of the typeface used for heading text, for example
/// `"AvenirNext-DemiBold"`. `nil` (the default) keeps the historical
/// behavior: headings render in the editor's base font with the bold
/// trait added.
///
/// The name is honored exactly, so the chosen face's weight and style
/// are respected — pick a `-Bold` / `-Semibold` face for heavier
/// headings. Emphasis inside a heading still composes on top of it:
/// bold / italic add their traits while the family and the per-level
/// size are kept. A name that doesn't resolve falls back to the default
/// heading font at draw time, so a typo degrades to the stock look
/// instead of changing metrics.
public var fontName: String?
/// Font-size multiplier per heading level (1...6).
public var fontMultipliers: [CGFloat]
/// Top spacing in `em` units per heading level (1...6).
public var topSpacingEm: [CGFloat]

public init(
fontName: String? = nil,
fontMultipliers: [CGFloat] = [2.0, 1.5, 1.17, 1.0, 0.83, 0.67],
topSpacingEm: [CGFloat] = [0.35, 0.30, 0.25, 0.20, 0.15, 0.10]
) {
self.fontName = fontName
self.fontMultipliers = fontMultipliers
self.topSpacingEm = topSpacingEm
}
Expand Down Expand Up @@ -462,6 +480,24 @@ public struct BlockquoteStyle: Sendable {
public static let `default` = BlockquoteStyle()
}

// MARK: - Tables

/// GFM table wrapper rendering knobs.
public struct TableStyle: Sendable {
/// Corner radius of the rendered table's outer wrapper. The interior
/// painting (header fill, separator rules) is clipped to the rounded
/// shape and the outer border rule is stroked along the rounded path,
/// so the rules stay crisp at the corners. `0` (the default) keeps the
/// historical square-cornered rendering exactly.
public var cornerRadius: CGFloat

public init(cornerRadius: CGFloat = 0) {
self.cornerRadius = max(0, cornerRadius)
}

public static let `default` = TableStyle()
}

// MARK: - Links

/// Foreground alpha values applied to link content in different states.
Expand Down
26 changes: 25 additions & 1 deletion Sources/MarkdownEngine/Configuration/MarkdownEditorTheme.swift
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,15 @@ public struct MarkdownEditorTheme: Sendable {
/// Foreground color for content the engine wants to deemphasize further
/// than `mutedText` — for example, broken wiki-links.
public var disabledText: NSColor
/// Foreground color for heading text. `nil` (the default) keeps the
/// historical behavior: headings render in ``bodyText`` like the rest
/// of the document.
///
/// Only the heading's own text takes this color. The `#` marker glyphs
/// stay on ``headingMarker``, and inline constructs inside a heading
/// (links, inline code, extension spans) keep their own colors, exactly
/// as they do over ``bodyText``.
public var headingText: NSColor?
/// Foreground color for heading marker glyphs (`#`, `##`, …).
public var headingMarker: NSColor

Expand Down Expand Up @@ -79,12 +88,22 @@ public struct MarkdownEditorTheme: Sendable {
/// Background color used for `==highlight==` inline markup.
public var highlightColor: NSColor

// MARK: Tables

/// Fill behind a rendered table's header row. `nil` (the default) keeps
/// the historical ``mutedText`` at 8% alpha.
public var tableHeaderBackground: NSColor?
/// Stroke color of a rendered table's outer border and internal rules.
/// `nil` (the default) keeps the historical ``mutedText`` at 50% alpha.
public var tableRule: NSColor?

// MARK: Init

public init(
bodyText: NSColor = .labelColor,
mutedText: NSColor = .secondaryLabelColor,
disabledText: NSColor = .tertiaryLabelColor,
headingText: NSColor? = nil,
headingMarker: NSColor = .gray,
link: NSColor = .linkColor,
incompleteLink: NSColor = .systemBlue,
Expand All @@ -93,11 +112,14 @@ public struct MarkdownEditorTheme: Sendable {
latexLightModeText: NSColor = .black,
latexDarkModeText: NSColor = .white,
strikethroughColor: NSColor = .labelColor,
highlightColor: NSColor = .systemOrange.withAlphaComponent(0.4)
highlightColor: NSColor = .systemOrange.withAlphaComponent(0.4),
tableHeaderBackground: NSColor? = nil,
tableRule: NSColor? = nil
) {
self.bodyText = bodyText
self.mutedText = mutedText
self.disabledText = disabledText
self.headingText = headingText
self.headingMarker = headingMarker
self.link = link
self.incompleteLink = incompleteLink
Expand All @@ -107,6 +129,8 @@ public struct MarkdownEditorTheme: Sendable {
self.latexDarkModeText = latexDarkModeText
self.strikethroughColor = strikethroughColor
self.highlightColor = highlightColor
self.tableHeaderBackground = tableHeaderBackground
self.tableRule = tableRule
}

/// System-native palette built from `NSColor` dynamic system colors.
Expand Down
22 changes: 18 additions & 4 deletions Sources/MarkdownEngine/Styling/MarkdownASTStyler.swift
Original file line number Diff line number Diff line change
Expand Up @@ -548,17 +548,31 @@ enum MarkdownASTStyler {

case .heading(let level, let range, let markers, let inlines):
let multiplier = ctx.config.headings.fontMultiplier(for: level)
let headingBase = NSFont(name: ctx.fontName, size: ctx.baseFont.pointSize * multiplier)
?? .systemFont(ofSize: ctx.baseFont.pointSize * multiplier)
let headingFont = adding(.bold, to: headingBase)
let headingSize = ctx.baseFont.pointSize * multiplier
// A configured heading face is honored exactly — its weight is the
// embedder's choice, so no synthetic bold on top. A name that
// doesn't resolve degrades to the stock heading font (base family,
// bold trait), mirroring TaskCheckboxStyle's symbol fallback.
let headingFont = ctx.config.headings.fontName
.flatMap { NSFont(name: $0, size: headingSize) }
?? adding(.bold, to: NSFont(name: ctx.fontName, size: headingSize)
?? .systemFont(ofSize: headingSize))
let lineHeight = ceil(headingFont.ascender - headingFont.descender + headingFont.leading) + 1
let headingPara = NSMutableParagraphStyle()
headingPara.minimumLineHeight = lineHeight
headingPara.maximumLineHeight = lineHeight
headingPara.paragraphSpacingBefore = headingFont.pointSize * ctx.config.headings.topSpacingEm(for: level)
headingPara.paragraphSpacing = ctx.baseParagraphSpacing
attrs.append((ctx.ns.paragraphRange(for: range), [.paragraphStyle: headingPara]))
attrs.append((range, [.font: headingFont]))
// theme.headingText paints the whole heading line; the marker loop
// and the inline descent below both append LATER, so `#` glyphs
// keep headingMarker and links / code keep their own ink — the
// same later-range-wins layering the bodyText default relies on.
var headingAttrs: [NSAttributedString.Key: Any] = [.font: headingFont]
if let headingText = ctx.theme.headingText {
headingAttrs[.foregroundColor] = headingText
}
attrs.append((range, headingAttrs))
for marker in markers {
attrs.append((marker, [.foregroundColor: ctx.theme.headingMarker]))
}
Expand Down
73 changes: 53 additions & 20 deletions Sources/MarkdownEngine/Styling/MarkdownStyler+Tables.swift
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,14 @@ extension MarkdownStyler {

private static func themeKeyPrefix(ctx: StylingContext, appearance: NSAppearance) -> String {
let theme = ctx.configuration.theme
func optionalIdentity(_ color: NSColor?) -> String {
color.map { "\(ObjectIdentifier($0))" } ?? "nil"
}
let identity = "\(ctx.baseFont.fontName)|\(ctx.baseFont.pointSize)|\(appearance.name.rawValue)|"
+ "\(ObjectIdentifier(theme.bodyText))|\(ObjectIdentifier(theme.mutedText))|"
+ "\(ObjectIdentifier(theme.highlightColor))|\(ObjectIdentifier(ctx.codeBackgroundColor))|"
+ "\(ObjectIdentifier(theme.latexLightModeText))|\(ObjectIdentifier(theme.latexDarkModeText))|"
+ "\(optionalIdentity(theme.tableHeaderBackground))|\(optionalIdentity(theme.tableRule))|"
+ "\(ObjectIdentifier(type(of: ctx.services.latex)))"

themeKeyLock.lock()
Expand All @@ -87,6 +91,8 @@ extension MarkdownStyler {
colorKey(ctx.codeBackgroundColor, under: appearance),
colorKey(theme.latexLightModeText, under: appearance),
colorKey(theme.latexDarkModeText, under: appearance),
theme.tableHeaderBackground.map { colorKey($0, under: appearance) } ?? "nil",
theme.tableRule.map { colorKey($0, under: appearance) } ?? "nil",
"\(ObjectIdentifier(type(of: ctx.services.latex)))",
].joined(separator: "|")

Expand Down Expand Up @@ -146,7 +152,11 @@ extension MarkdownStyler {
// highlighted under one config and literal under another — those must
// never share a cached image.
let extensionKey = ctx.configuration.extensionRegistry.fingerprint
let key = (themeKeyPrefix(ctx: ctx, appearance: appearance) + "|x\(extensionKey)|w\(widthKey)|" + source) as NSString
// The wrapper radius changes the rendered pixels, so it is part of
// the cache identity like every other rendering input.
let radiusKey = ctx.configuration.table.cornerRadius
let key = (themeKeyPrefix(ctx: ctx, appearance: appearance)
+ "|x\(extensionKey)|w\(widthKey)|r\(radiusKey)|" + source) as NSString
if let cached = tableImageCache.object(forKey: key) {
return (cached, false)
}
Expand All @@ -158,7 +168,8 @@ extension MarkdownStyler {
latex: ctx.services.latex,
appearance: appearance,
availableWidth: availableWidth,
extensions: ctx.configuration.extensions
extensions: ctx.configuration.extensions,
cornerRadius: ctx.configuration.table.cornerRadius
)
tableImageCache.setObject(image, forKey: key)
return (image, true)
Expand Down Expand Up @@ -453,21 +464,25 @@ extension MarkdownStyler {
latex: any LatexRenderer,
appearance: NSAppearance,
availableWidth: CGFloat,
extensions: [any MarkdownExtension] = []
extensions: [any MarkdownExtension] = [],
cornerRadius: CGFloat = 0
) -> NSImage {
let columnCount = table.alignments.count
let cellHPadding: CGFloat = 12
let cellVPadding: CGFloat = 6
let borderWidth: CGFloat = 1
// Resolve under the real appearance: `.withAlphaComponent()` freezes a dynamic color otherwise.
func mutedColor(alpha: CGFloat) -> NSColor {
var resolved: NSColor = theme.mutedText
func resolved(_ color: NSColor) -> NSColor {
var result = color
appearance.performAsCurrentDrawingAppearance {
resolved = theme.mutedText.usingColorSpace(.sRGB) ?? theme.mutedText
result = color.usingColorSpace(.sRGB) ?? color
}
return resolved.withAlphaComponent(alpha)
return result
}
func mutedColor(alpha: CGFloat) -> NSColor {
resolved(theme.mutedText).withAlphaComponent(alpha)
}
let borderColor = mutedColor(alpha: 0.5)
let borderColor = theme.tableRule.map(resolved) ?? mutedColor(alpha: 0.5)
let baseLineHeight: CGFloat = ceil(baseFont.ascender - baseFont.descender + baseFont.leading)
let minColumnContentWidth: CGFloat = 16

Expand Down Expand Up @@ -598,10 +613,31 @@ extension MarkdownStyler {
}

let alignments = table.alignments
let headerFill = mutedColor(alpha: 0.08)
let headerFill = theme.tableHeaderBackground.map(resolved) ?? mutedColor(alpha: 0.08)

// Clamp so tiny tables can't invert the rounded path.
let radius = max(0, min(cornerRadius, min(size.width, size.height) / 2 - borderWidth))
let outerRect = NSRect(
x: borderWidth / 2,
y: borderWidth / 2,
width: size.width - borderWidth,
height: size.height - borderWidth
)

// Flipped image so AppKit handles the y-flip; a manual transform mirror would flip glyphs too.
return NSImage(size: size, flipped: true) { _ in
// Rounded wrapper: the outer border stroke runs along the rounded
// path, and the interior painting (header fill, separator rule
// ends) is clipped to it so nothing pokes out of the corners.
let outer = radius > 0
? NSBezierPath(roundedRect: outerRect, xRadius: radius, yRadius: radius)
: NSBezierPath(rect: outerRect)

if radius > 0 {
NSGraphicsContext.saveGraphicsState()
outer.addClip()
}

// Header row fill
headerFill.setFill()
NSBezierPath(rect: NSRect(
Expand All @@ -611,17 +647,6 @@ extension MarkdownStyler {
height: rowContentHeights[0] + 2 * cellVPadding
)).fill()

// Outer border
borderColor.setStroke()
let outer = NSBezierPath(rect: NSRect(
x: borderWidth / 2,
y: borderWidth / 2,
width: size.width - borderWidth,
height: size.height - borderWidth
))
outer.lineWidth = borderWidth
outer.stroke()

// Internal separators
let separators = NSBezierPath()
separators.lineWidth = borderWidth
Expand All @@ -637,6 +662,14 @@ extension MarkdownStyler {
}
separators.stroke()

if radius > 0 { NSGraphicsContext.restoreGraphicsState() }

// Outer border — stroked unclipped so the rule stays crisp at
// the rounded corners.
borderColor.setStroke()
outer.lineWidth = borderWidth
outer.stroke()

func drawCell(_ s: NSAttributedString, col: Int, row: Int) {
guard col < columnCount else { return }
let cellLeft = columnLeft[col] + cellHPadding
Expand Down
Loading