Skip to content

feat: add implementation for wasi sock functions #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

mhdawson
Copy link
Member

No description provided.

@mhdawson mhdawson force-pushed the oscar/sockets branch 2 times, most recently from 4c34720 to 6084fee Compare July 28, 2023 16:02
@mhdawson
Copy link
Member Author

@cjihrig, @ospencer PR to add the sockets implementation to the main line.

Co-authored-by: Oscar Spencer <[email protected]>
Co-authored-by: Michael Dawson <[email protected]>

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson mhdawson changed the title Oscar/sockets feat: add implementation for wasi sock functions Jul 28, 2023
Copy link
Collaborator

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is just #214 targeted at main, then RSLGTM

@mhdawson
Copy link
Member Author

@cjihrig that's it with merge conflicts resolved. Mostly because of me fixing the windows tests in both:)

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Fantastic work @mhdawson—really appreciate you getting this over the line.

@mhdawson mhdawson merged commit 2c14ae9 into main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants