Skip to content

Conversation

@bjohansebas
Copy link
Member

Description

As the title says, I don’t think we should keep logos that we’re not using. If at some point we’re allowed to use the logo because an agreement is reached, then we can obtain it again.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Oct 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 19, 2025 6:22pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.44%. Comparing base (7015095) to head (d137c10).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8242      +/-   ##
==========================================
- Coverage   76.45%   76.44%   -0.02%     
==========================================
  Files         115      115              
  Lines        9643     9643              
  Branches      317      317              
==========================================
- Hits         7373     7372       -1     
- Misses       2269     2270       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjohansebas bjohansebas marked this pull request as ready for review October 19, 2025 18:24
@bjohansebas bjohansebas requested a review from a team as a code owner October 19, 2025 18:24
Copilot AI review requested due to automatic review settings October 19, 2025 18:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes unused partner logo components from the UI components package and reduces the PartnerLogos barrel to only export the logos still in use.

  • Deletes directories and components for unused partner logos (e.g., ARM, Crowdin, DataDog, EquinixMetal, IBM, OpenSSF, Rackspace, Scaleway, Sentry, Vlt)
  • Updates the PartnerLogos index to only import and export the remaining logos
  • Streamlines the package surface area to only the currently used partner logos

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/ui-components/src/Icons/PartnerLogos/index.ts Shrinks the barrel to export only the remaining in-use logos; removes imports/exports for deleted logos
packages/ui-components/src/Icons/PartnerLogos/Vlt/* Removes Vlt logo components and index
packages/ui-components/src/Icons/PartnerLogos/Sentry/* Removes Sentry logo components and index
packages/ui-components/src/Icons/PartnerLogos/Scaleway/* Removes Scaleway logo components and index
packages/ui-components/src/Icons/PartnerLogos/Rackspace/* Removes Rackspace logo components and index
packages/ui-components/src/Icons/PartnerLogos/OpenSSF/* Removes OpenSSF logo components and index
packages/ui-components/src/Icons/PartnerLogos/IBM/* Removes IBM logo components and index
packages/ui-components/src/Icons/PartnerLogos/EquinixMetal/* Removes EquinixMetal logo components and index
packages/ui-components/src/Icons/PartnerLogos/DataDog/* Removes DataDog logo components and index
packages/ui-components/src/Icons/PartnerLogos/Crowdin/* Removes Crowdin logo components and index
packages/ui-components/src/Icons/PartnerLogos/ARM/* Removes ARM logo components and index

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is overreach - we partner with many of these organizations - especially through direct usage and their in-kind sponsorship.

I'd rather we cut issues for each here and determine how we want to add them to the sponsors page.

@bjohansebas
Copy link
Member Author

The problem isn’t how we want to add them, it’s that we’re not allowed to use their logos. The only logos we’re permitted to use are the ones listed here: https://openjsf.org/partners. That’s the list the foundation provided me.

I’m not sure about the status of the other companies with the foundation, even though we do use their services or machines.

@bmuenzenmeyer
Copy link
Contributor

Apologies - I assume this surfaced as part of #7991.
Do you know if any efforts started to approach them?

@avivkeller
Copy link
Member

This lowers the bundle size from ~2.6 mb to 2.33 mb!

@ovflowd
Copy link
Member

ovflowd commented Oct 19, 2025

They are probably being bundled due to wildcard imports. We should treeshake them.

@ovflowd
Copy link
Member

ovflowd commented Oct 19, 2025

But I do feel we should keep the logos tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants