Skip to content

Conversation

micheleriva
Copy link
Contributor

This PR supersedes #7971 and integrates the new Orama components, powered by the new OramaCore backend.

Description

New components - React-based to replace the old WebComponents-based ones. New backend (OramaCore instead of old Orama Cloud), all hosted and maintained on https://app.orama.com. Credentials have been shared privately with the repository maintainers on Slack.

Validation

Tested locally and on remote demo environment.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

g-francesca and others added 30 commits July 9, 2025 11:54
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
@g-francesca
Copy link

g-francesca commented Sep 24, 2025

@node-core/website:dev:  ⨯ Error: Endpoint and API Key are required to create a Profile
@node-core/website:dev:     at __TURBOPACK__module__evaluation__ (components\Common\Searchbox\index.tsx:29:15)
@node-core/website:dev:     at __TURBOPACK__module__evaluation__ (components\withNavBar.tsx:21:1)
@node-core/website:dev:     at <unknown> (layouts\GlowingBackdrop.tsx:6:1)
@node-core/website:dev:     at __TURBOPACK__module__evaluation__ (C:\Users\telav\Documents\projects\nodejs.org\apps\site\.next\server\chunks\ssr\[root-of-the-server]__35d9ee3d._.js:7550:30)
@node-core/website:dev:     at <unknown> (app\global-error.tsx:8:1)
@node-core/website:dev:     at __TURBOPACK__module__evaluation__ (C:\Users\telav\Documents\projects\nodejs.org\apps\site\.next\server\chunks\ssr\[root-of-the-server]__35d9ee3d._.js:7616:30)
@node-core/website:dev:   27 | import { SlidingChatPanel } from './SlidingChatPanel';
@node-core/website:dev:   28 |
@node-core/website:dev: > 29 | const orama = new OramaCloud({
@node-core/website:dev:      |               ^
@node-core/website:dev:   30 |   projectId: ORAMA_CLOUD_PROJECT_ID,
@node-core/website:dev:   31 |   apiKey: ORAMA_CLOUD_READ_API_KEY,
@node-core/website:dev:   32 | }); {
@node-core/website:dev:   digest: '184109325',
@node-core/website:dev:   page: '/en'

This needs to work in a way where users can locally use the site

Right, I’m now first checking if the orama env variables are defined. Otherwise, I set orama to null and disable the SearchButton. Wdyt? @avivkeller

@g-francesca
Copy link

@avivkeller @canerakdas I've fixed the points reported. Thank you for your review. Please let me know if there's anything else to adjust. Thank you!

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, I’ve added my final comments as well. Thank you for the quick responses 🚀

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work!

@g-francesca
Copy link

Apologies for the delay, I’ve added my final comments as well. Thank you for the quick responses 🚀

Thank you! I'll cover them today!

@g-francesca
Copy link

Apologies for the delay, I’ve added my final comments as well. Thank you for the quick responses 🚀

Thank you! I'll cover them today!

@avivkeller @canerakdas fyi I've addressed the latest points reported, thank you.

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.65%. Comparing base (5140729) to head (8667e5c).
⚠️ Report is 13 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8175      +/-   ##
==========================================
+ Coverage   76.58%   76.65%   +0.07%     
==========================================
  Files         115      115              
  Lines        9602     9627      +25     
  Branches      322      322              
==========================================
+ Hits         7354     7380      +26     
+ Misses       2247     2246       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work 🚀 🐢

@avivkeller
Copy link
Member

@g-francesca Can you fix or remove the playwright tests? After that, this'll be ready to land!

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 60 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 96 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 94 🟢 100 🟢 96 🟢 100 🔗
/en/download/archive/current 🟢 99 🟢 100 🟢 96 🟢 100 🔗
/en/blog 🟢 98 🟢 100 🟢 96 🟢 100 🔗

import { OramaCloud } from '@orama/core';

import { getDocuments } from './get-documents.mjs';
import { siteContent } from './get-documents.mjs';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { siteContent } from './get-documents.mjs';
import { getDocuments } from './get-documents.mjs';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This export is getDocuments, not siteContent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I've replaced it

@g-francesca
Copy link

g-francesca commented Oct 6, 2025

@g-francesca Can you fix or remove the playwright tests? After that, this'll be ready to land!

Yes! Some selectors were still targeting old web components. @avivkeller I added data-testid attributes to the new React components and updated the Playwright locators accordingly. Can you please double-check? TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants