-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(search): use new Orama components #8175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Right, I’m now first checking if the orama env variables are defined. Otherwise, I set |
@avivkeller @canerakdas I've fixed the points reported. Thank you for your review. Please let me know if there's anything else to adjust. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, I’ve added my final comments as well. Thank you for the quick responses 🚀
apps/site/components/Common/Searchbox/ChatInteractions/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work!
Thank you! I'll cover them today! |
@avivkeller @canerakdas fyi I've addressed the latest points reported, thank you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8175 +/- ##
==========================================
+ Coverage 76.58% 76.65% +0.07%
==========================================
Files 115 115
Lines 9602 9627 +25
Branches 322 322
==========================================
+ Hits 7354 7380 +26
+ Misses 2247 2246 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work 🚀 🐢
@g-francesca Can you fix or remove the playwright tests? After that, this'll be ready to land! |
Lighthouse Results
|
import { OramaCloud } from '@orama/core'; | ||
|
||
import { getDocuments } from './get-documents.mjs'; | ||
import { siteContent } from './get-documents.mjs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { siteContent } from './get-documents.mjs'; | |
import { getDocuments } from './get-documents.mjs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This export is getDocuments
, not siteContent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I've replaced it
Yes! Some selectors were still targeting old web components. @avivkeller I added |
This PR supersedes #7971 and integrates the new Orama components, powered by the new OramaCore backend.
Description
New components - React-based to replace the old WebComponents-based ones. New backend (OramaCore instead of old Orama Cloud), all hosted and maintained on https://app.orama.com. Credentials have been shared privately with the repository maintainers on Slack.
Validation
Tested locally and on remote demo environment.
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.