-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(learn): clarify intro to Node.js #8004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Revise for clarity. Signed-off-by: E <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not better
Actually, I think that entire sentence is already a run-on. @toocomputer would you mind rephrasing the entire sentence into 2-3 sentences? |
Not a run-on, @avivkeller, but not particularly clear either, at least not on first glance. How's this (+ @AugustinMauroy)? Node.js provides a set of asynchronous I/O primitives in its standard library that prevent JavaScript code from blocking. In addition, libraries in Node.js are generally written using non-blocking paradigms. Accordingly, blocking behavior is the exception rather than the norm in Node.js. |
I like it! |
Signed-off-by: E <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
I wonder if you might consider giving more thoughtful and constructive feedback for PRs in the future, @AugustinMauroy. As is stands, your initial comment comes off as brusque to the point of being rude; but more importantly, it's not helpful. The sentence wasn't clear to me (initially), so I tried my hand (spending my own valuable time and energy) at making it better. The way your comment reads discourages and disincentivizes people who are trying to help. |
no now it's good ! Your first proposed change was just a comma, so I was considering the potential relevance of the pr |
Got it. It probably would've been helpful on my end as well to be more descriptive in terms of what I felt the issue was with the sentence and why it was unclear. Anyway, thanks for reviewing 🖖🏼 |
To be honest, there are more and more people who want to contribute with LLM, so when I see that we've changed just a comma, I'm always suspicious. Because sometimes these people go so far as to respond to the review with ChatGPT or something else. I hope I didn't upset you. And thank you for your contribution. |
Lighthouse Results
|
thanks for clarifying @AugustinMauroy. the feedback definitely rubbed me the rub wrong way, but i totally get your point about having to be wary. it's a shame how some people have ruined it for folks who are genuinely trying to be helpful. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #8004 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 95 95
Lines 8308 8308
Branches 214 214
=======================================
Hits 6063 6063
Misses 2244 2244
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Revise wording for clarity.
Description
Validation
Related Issues
Check List
I have runN/Apnpm format
to ensure the code follows the style guide.I have runN/Apnpm test
to check if all tests are passing.I have runN/Apnpm build
to check if the website builds without errors.I've covered new added functionality with unit tests if necessary.N/A