Skip to content

fix(learn): clarify intro to Node.js #8004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Conversation

toocomputer
Copy link
Contributor

Revise wording for clarity.

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide. N/A
  • I have run pnpm test to check if all tests are passing. N/A
  • I have run pnpm build to check if the website builds without errors. N/A
  • I've covered new added functionality with unit tests if necessary. N/A

Revise for clarity.

Signed-off-by: E <[email protected]>
@toocomputer toocomputer requested a review from a team as a code owner July 21, 2025 20:07
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 21, 2025 10:21pm

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not better

@avivkeller
Copy link
Member

avivkeller commented Jul 21, 2025

Actually, I think that entire sentence is already a run-on. @toocomputer would you mind rephrasing the entire sentence into 2-3 sentences?

@toocomputer
Copy link
Contributor Author

Not a run-on, @avivkeller, but not particularly clear either, at least not on first glance.

How's this (+ @AugustinMauroy)?

Node.js provides a set of asynchronous I/O primitives in its standard library that prevent JavaScript code from blocking. In addition, libraries in Node.js are generally written using non-blocking paradigms. Accordingly, blocking behavior is the exception rather than the norm in Node.js.

@avivkeller
Copy link
Member

I like it!

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@avivkeller avivkeller changed the title Update introduction-to-nodejs.md fix(learn): clarify intro to Node.js Jul 22, 2025
@toocomputer
Copy link
Contributor Author

I wonder if you might consider giving more thoughtful and constructive feedback for PRs in the future, @AugustinMauroy.

As is stands, your initial comment comes off as brusque to the point of being rude; but more importantly, it's not helpful.

The sentence wasn't clear to me (initially), so I tried my hand (spending my own valuable time and energy) at making it better.

The way your comment reads discourages and disincentivizes people who are trying to help.

@AugustinMauroy
Copy link
Member

no now it's good ! Your first proposed change was just a comma, so I was considering the potential relevance of the pr

@toocomputer
Copy link
Contributor Author

Got it. It probably would've been helpful on my end as well to be more descriptive in terms of what I felt the issue was with the sentence and why it was unclear.

Anyway, thanks for reviewing 🖖🏼

@AugustinMauroy
Copy link
Member

Got it. It probably would've been helpful on my end as well to be more descriptive in terms of what I felt the issue was with the sentence and why it was unclear.

Anyway, thanks for reviewing 🖖🏼

To be honest, there are more and more people who want to contribute with LLM, so when I see that we've changed just a comma, I'm always suspicious.

Because sometimes these people go so far as to respond to the review with ChatGPT or something else.

I hope I didn't upset you. And thank you for your contribution.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 23, 2025
@ovflowd ovflowd enabled auto-merge July 23, 2025 12:57
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 23, 2025
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🔴 66 🔗
/en/about 🟢 100 🟢 97 🟢 100 🔴 58 🔗
/en/about/previous-releases 🟢 98 🟢 93 🟢 100 🔴 61 🔗
/en/download 🟢 93 🟢 100 🟢 100 🔴 66 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🔴 69 🔗

@toocomputer
Copy link
Contributor Author

thanks for clarifying @AugustinMauroy. the feedback definitely rubbed me the rub wrong way, but i totally get your point about having to be wary.

it's a shame how some people have ruined it for folks who are genuinely trying to be helpful.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.97%. Comparing base (0122397) to head (211571a).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8004   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files          95       95           
  Lines        8308     8308           
  Branches      214      214           
=======================================
  Hits         6063     6063           
  Misses       2244     2244           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovflowd ovflowd added this pull request to the merge queue Jul 23, 2025
Merged via the queue into nodejs:main with commit 2d1abe5 Jul 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants