Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump orama version #7577

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

rjborba
Copy link
Contributor

@rjborba rjborba commented Mar 27, 2025

Description

This PR updates the @orama/react-components package from version 0.5.1 to 0.6.4. This update brings in several improvements and bug fixes to the search components used in the website.

Validation

The changes have been validated by:

  1. Running npm install to update the dependencies
  2. Running npm run build to ensure the website builds successfully
  3. Testing the search functionality to ensure it works as expected with the new version

Related Issues

7534

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

The changes in this PR are focused on updating a single dependency version, which is a straightforward change that doesn't require additional test coverage since we're using the official package from npm.

@rjborba rjborba requested a review from a team as a code owner March 27, 2025 14:49
Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 27, 2025 2:50pm

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 89 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

@avivkeller
Copy link
Member

✅ I've confirmed that this resolves the issue! Thanks, @rjborba!

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.74% (500/590) 76.03% (165/217) 87.09% (108/124)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.619s ⏱️
@nodejs/website 157 0 💤 0 ❌ 0 🔥 6.35s ⏱️

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks

@avivkeller avivkeller added this pull request to the merge queue Mar 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2025
@ovflowd
Copy link
Member

ovflowd commented Mar 27, 2025

Is the failure related to the change, @rjborba (?)

@avivkeller
Copy link
Member

avivkeller commented Mar 27, 2025

I wonder why that didn't fail during github_actions:pull-request Trigger Pull Request Checks ? Let's see if it'll happen again

Edit: nope

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Mar 28, 2025
Merged via the queue into nodejs:main with commit 9e89ab6 Mar 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White border in the search modal.
6 participants