Skip to content

fix: modified css module #7570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

fix: modified css module #7570

merged 3 commits into from
Mar 25, 2025

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Mar 25, 2025

Description

The css-module was modified I just copy the previous one. Also remove local in pathname to fix active link detection.

Validation

Capture d’écran 2025-03-25 à 10 38 52

Related Issues

Close #7569

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Sorry, something went wrong.

@Copilot Copilot AI review requested due to automatic review settings March 25, 2025 09:02
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner March 25, 2025 09:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • packages/ui-components/Containers/Sidebar/SidebarItem/index.module.css: Language not supported

Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 25, 2025 9:51am

@ovflowd
Copy link
Member

ovflowd commented Mar 25, 2025

Does this also fix the bug in the logo?

Copy link
Contributor

github-actions bot commented Mar 25, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 60 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 89 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Mar 25, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.74% (500/590) 76.03% (165/217) 87.09% (108/124)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 5.227s ⏱️
@nodejs/website 157 0 💤 0 ❌ 0 🔥 6.712s ⏱️

@AugustinMauroy
Copy link
Member Author

Does this also fix the bug in the logo?

Nop I didn't get how to fix logo issue. Because dark still Is correctly applied on dark theme and correctly remove on light theme.

But it's didn't applied light style.

@ovflowd
Copy link
Member

ovflowd commented Mar 25, 2025

Does this also fix the bug in the logo?

Nop I didn't get how to fix logo issue. Because dark still Is correctly applied on dark theme and correctly remove on light theme.

But it's didn't applied light style.

I think we pass to the logo what theme we are at or something? @avivkeller if you can investigate as a follow-up 🙏

@AugustinMauroy
Copy link
Member Author

Does this also fix the bug in the logo?

Nop I didn't get how to fix logo issue. Because dark still Is correctly applied on dark theme and correctly remove on light theme.
But it's didn't applied light style.

I think we pass to the logo what theme we are at or something? @avivkeller if you can investigate as a follow-up 🙏

We define it by tailwind classes

className={classNames('fill-[#333333] dark:fill-white', className)}

@AugustinMauroy
Copy link
Member Author

I'm fast tracking because it's affect a lot user

Merged via the queue into main with commit b0b5164 Mar 25, 2025
22 checks passed
@AugustinMauroy AugustinMauroy deleted the fix-css branch March 25, 2025 10:18
@avivkeller
Copy link
Member

I think we pass to the logo what theme we are at or something? @avivkeller if you can investigate as a follow-up 🙏

Yep! I'll be on that ASAP.

@AugustinMauroy
Copy link
Member Author

Yep! I'll be on that ASAP.

Thanks 🫶🏻

@avivkeller
Copy link
Member

Okay. I'm so sorry about the UI differences, I'm currently looking into it and will open a PR as soon I as complete my investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CSS style classes on about page left sidebar
3 participants