Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content(learn): update resources about typescript #6951

Merged
merged 10 commits into from
Sep 16, 2024
Merged

content(learn): update resources about typescript #6951

merged 10 commits into from
Sep 16, 2024

Conversation

AugustinMauroy
Copy link
Contributor

Description

Updating ressources about typescript

Validation

  • redirect should work
  • example should be correct

Related Issues

nodejs/node#53725 (comment)

@vercel Vercel
Copy link

vercel bot commented Jul 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Sep 14, 2024 1:19pm

@AugustinMauroy AugustinMauroy marked this pull request as ready for review July 28, 2024 19:15
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner July 28, 2024 19:15
@AugustinMauroy
Copy link
Contributor Author

CC @marco-ippolito 👋
BTW: thank you for everything you've done

@AugustinMauroy AugustinMauroy added the content Issues/pr concerning content label Jul 28, 2024
@marco-ippolito marco-ippolito changed the title content(learn): update ressources about typescript content(learn): update resources about typescript Jul 30, 2024
@AugustinMauroy AugustinMauroy mentioned this pull request Aug 9, 2024
Closed
aagamezl
aagamezl reviewed Aug 9, 2024
View reviewed changes
apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved
apps/site/i18n/locales/en.json Outdated Show resolved Hide resolved
@mikeesto mikeesto mentioned this pull request Sep 5, 2024
Closed
5 tasks
@AugustinMauroy AugustinMauroy added the learn Issues/pr concerning the learn section label Sep 13, 2024
bmuenzenmeyer
bmuenzenmeyer reviewed Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this is an excellent primer, thanks @AugustinMauroy

I gave it a pass with a critical eye.

apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/introduction.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/run-natively.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/run-natively.md Show resolved Hide resolved
apps/site/pages/en/learn/typescript/run.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/run.md Outdated Show resolved Hide resolved
@AugustinMauroy @bmuenzenmeyer
Update from feedback
43f5c59 
Co-Authored-By: Brian Muenzenmeyer <[email protected]>
@AugustinMauroy
Copy link
Contributor Author

@bmuenzenmeyer I've applied your review. Thanks a lot.

@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Sep 15, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 15, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 87 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

@github-actions GitHub Actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.265s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit d164714 Sep 16, 2024
15 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the content(learn)-typescript branch September 16, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagamezl aagamezl aagamezl left review comments

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@aymen94 aymen94 aymen94 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
content Issues/pr concerning content learn Issues/pr concerning the learn section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AugustinMauroy @bmuenzenmeyer @aymen94 @aduh95 @marco-ippolito @aagamezl