Skip to content

fix: add redirection from /dist to /dist/ #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

UlisesGascon
Copy link
Member

Description

This is a simple redirection from /dist to /dist/.

Validation

Related Issues

Full context in nodejs/docker-node#1945.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@UlisesGascon UlisesGascon requested a review from a team as a code owner August 10, 2023 09:27
@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 9:28am

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.42% (366/396) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 12.201s ⏱️

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovflowd
Copy link
Member

ovflowd commented Aug 10, 2023

@targos I assume Caching Rules also need to be updated then? https://dash.cloudflare.com/07be8d2fbc940503ca1be344714cb0d1/nodejs.org/caching/cache-rules

@targos
Copy link
Member

targos commented Aug 10, 2023

@ovflowd Updated as well.

@ovflowd
Copy link
Member

ovflowd commented Aug 10, 2023

@targos
Copy link
Member

targos commented Aug 10, 2023

aaaargh, done :D

@UlisesGascon
Copy link
Member Author

thanks @targos and @ovflowd! I will close this PR then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants