deps: call OPENSSL_free after ANS1_STRING_to_UTF8 #60609
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dependencies
RafaelGSS
added
fast-track
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
Co-Authored-By: Chris Smith <[email protected]> Signed-off-by: RafaelGSS <[email protected]>
RafaelGSS
force-pushed
the
fix-leak-ANS1_STRING_to_UTF8
branch
from
e06e579 to
615f5cd
Compare
smithc
reviewed
Nov 6, 2025
Co-authored-by: smithc <[email protected]>
smithc
reviewed
Nov 6, 2025
| return { | ||
| std::move(name_str), | ||
| std::string(reinterpret_cast<const char*>(value_str), value_str_size)}; | ||
| std::move(out) |
There was a problem hiding this comment.
Sorry, this latest test failure is my mistake with the previous suggestion; we're just missing the closing brace and semi-colon here at the end of this line.
Suggested change
| std::move(out) | |
| std::move(out)}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @mcollina @jasnell @smithc
Refs: #58380
I took the liberty to add you as Co-Authored-By - I hope you don't mind. Can you check if I'm using your best email?