Skip to content

Conversation

@marco-ippolito
Copy link
Member

Fixes: #60599

The issue was that:

  std::string env_file;
  std::string optional_env_file;

were marked as a string while multiple values were supported.
I added a test to make sure we dont support comma separated values

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Nov 6, 2025
@marco-ippolito marco-ippolito added watch-mode Issues and PRs related to watch mode dotenv Issues and PRs related to .env file parsing labels Nov 6, 2025
@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (e72761f) to head (2fe75ac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60605      +/-   ##
==========================================
- Coverage   88.57%   88.54%   -0.04%     
==========================================
  Files         704      704              
  Lines      208087   208087              
  Branches    40090    40084       -6     
==========================================
- Hits       184306   184243      -63     
- Misses      15849    15882      +33     
- Partials     7932     7962      +30     
Files with missing lines Coverage Δ
src/node_options.h 97.86% <ø> (ø)

... and 51 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. config Issues or PRs related to the config subsystem dotenv Issues and PRs related to .env file parsing needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple --env-file no longer work with --watch

6 participants