-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
src: tag v8 aligned pointer slots with embedder data type tags #60602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60602 +/- ##
==========================================
- Coverage 88.56% 88.54% -0.03%
==========================================
Files 704 704
Lines 208077 208085 +8
Branches 40084 40082 -2
==========================================
- Hits 184289 184253 -36
- Misses 15826 15867 +41
- Partials 7962 7965 +3
🚀 New features to boost your workflow:
|
joyeecheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM. I feel that it'd be nicer to add a method to BaseObject that allows setting arbitrary slot with the tag so that we don't have to repeat the default argument in all its subclasses, but that can be a followup
Many of the changed lines in this PR are not in the subclasses of |
Fixes: #60589