Skip to content

src: avoid C strings in more C++ exception throws #60592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2025
Merged

src: avoid C strings in more C++ exception throws #60592

merged 2 commits into from
Nov 7, 2025

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Nov 5, 2025

Similar to 2e2f4cd, just missed them in that commit.

@addaleax
src: avoid C strings in more C++ exception throws
5ef9d0b 
Similar to 2e2f4cd, just missed them in that commit.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 5, 2025
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (fa9918e) to head (cf80eb8).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #60592   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files         704      704           
  Lines      208077   208069    -8     
  Branches    40084    40074   -10     
=======================================
  Hits       184269   184269           
+ Misses      15833    15824    -9     
- Partials     7975     7976    +1
Files with missing lines Coverage Δ
src/debug_utils-inl.h 83.33% <100.00%> (+0.33%) ⬆️
src/node_file.cc 75.50% <100.00%> (-0.10%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70061/

@addaleax addaleax added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70064/

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 368eb4c into nodejs:main Nov 7, 2025
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 7, 2025

Landed in 368eb4c

aduh95 pushed a commit that referenced this pull request Nov 10, 2025
@addaleax @aduh95
src: avoid C strings in more C++ exception throws
a6c2213 
Similar to 2e2f4cd, just missed them in that commit.

PR-URL: #60592
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@legendecas legendecas legendecas approved these changes

@juanarbol juanarbol juanarbol approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addaleax @nodejs-github-bot @anonrig @cjihrig @legendecas @juanarbol @marco-ippolito