fix abortsignal: make AbortSignal.timeout mock-timers compatible #60587
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#60565 Refs: nodejs#60494 Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-11-03.md Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]>
Renegade334
reviewed
Nov 6, 2025
There was a problem hiding this comment.
The DOM standard does not use setTimeout for this method, and changes to the public-facing timers API should not be observable here.
The correct route would probably be to add this as a discrete API target for the mocker (ie. enabled via mocks.timers.enable({ apis: ['AbortSignal.timeout'] })) with its own implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60509
AbortSignal.timeout()previously usedinternal/timers.setTimeout, which was not intercepted bymock.timers.enable().This change updates it to use
globalThis.setTimeoutandglobalThis.clearTimeout, somock.timers.tick()correctly triggers aborts./cc @nodejs/testing
Notes for reviewers
This change replaces
require('internal/timers')usage with global timers,so
mock.timersin the Node test runner can interceptAbortSignal.timeout.Verified locally that the fix aligns with issue reproduction steps.