v8: adding total_allocated_bytes to HeapStatistics #60573
Merged
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
caiolima
force-pushed
the
expose-total-allocated-bytes
branch
from
611be50 to
0f52825
Compare
caiolima
changed the title
Member
|
The subsystem should be |
caiolima
changed the title
caiolima
force-pushed
the
expose-total-allocated-bytes
branch
from
0f52825 to
b198157
Compare
Contributor
Author
Changed. Thanks! |
theanarkh
approved these changes
Nov 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60573 +/- ##
==========================================
+ Coverage 88.55% 88.56% +0.01%
==========================================
Files 704 704
Lines 207981 208075 +94
Branches 40068 40080 +12
==========================================
+ Hits 184173 184281 +108
+ Misses 15854 15831 -23
- Partials 7954 7963 +9
🚀 New features to boost your workflow:
|
legendecas
reviewed
Nov 4, 2025
addaleax
approved these changes
Nov 4, 2025
addaleax
added
semver-minor
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Nov 4, 2025
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
legendecas
approved these changes
Nov 4, 2025
cjihrig
approved these changes
Nov 4, 2025
marco-ippolito
approved these changes
Nov 4, 2025
jasnell
approved these changes
Nov 5, 2025
Collaborator
Contributor
Author
|
Hi all, thank you very much for the reviews here. Looking into those failures, they seem unrelated to my patch. Could anybody trigger CI again to me, please? |
Collaborator
Collaborator
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ed6569c |
Contributor
Author
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to Node's HeapStatistics API a new field called
total_allocated_bytesthat contains the total bytes allocated since the creation of an isolate. This extension comes from the extension added recently in V8 on v8/v8@fe81545. The major use case for this information is to allow creating of regression tests tracking allocations.