Skip to content

Conversation

addaleax
Copy link
Member

Since 075936b, TriggerNodeReport() takes std::string_view arguments directly.

Since 075936b, `TriggerNodeReport()` takes `std::string_view`
arguments directly.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 10, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. labels Oct 10, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (e105e82) to head (ad00d97).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60201      +/-   ##
==========================================
+ Coverage   88.53%   88.56%   +0.03%     
==========================================
  Files         704      704              
  Lines      208087   208087              
  Branches    40006    40017      +11     
==========================================
+ Hits       184223   184288      +65     
+ Misses      15869    15815      -54     
+ Partials     7995     7984      -11     
Files with missing lines Coverage Δ
src/node_report_module.cc 87.70% <100.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants