-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
src: use string_view in WriteReport()
#60201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
addaleax
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
addaleax:node-report-string-conversions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 075936b, `TriggerNodeReport()` takes `std::string_view` arguments directly.
cjihrig
approved these changes
Oct 10, 2025
richardlau
approved these changes
Oct 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60201 +/- ##
==========================================
+ Coverage 88.53% 88.56% +0.03%
==========================================
Files 704 704
Lines 208087 208087
Branches 40006 40017 +11
==========================================
+ Hits 184223 184288 +65
+ Misses 15869 15815 -54
+ Partials 7995 7984 -11
🚀 New features to boost your workflow:
|
lpinca
approved these changes
Oct 10, 2025
anonrig
approved these changes
Oct 10, 2025
daeyeon
approved these changes
Oct 11, 2025
RaisinTen
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
commit-queue
Add this label to land a pull request using GitHub Actions.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v24.x
PRs that should not land on the v24.x-staging branch and should not be released in v24.x.
needs-ci
PRs that need a full CI run.
report
Issues and PRs related to process.report.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 075936b,
TriggerNodeReport()
takesstd::string_view
arguments directly.