-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
vm: hint module identifier in instantiate errors #60199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
cjihrig
approved these changes
Oct 10, 2025
addaleax
reviewed
Oct 10, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60199 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 704 704
Lines 208087 208085 -2
Branches 40006 40004 -2
=======================================
+ Hits 184223 184224 +1
- Misses 15869 15871 +2
+ Partials 7995 7990 -5
🚀 New features to boost your workflow:
|
aduh95
approved these changes
Oct 11, 2025
RaisinTen
approved these changes
Oct 11, 2025
addaleax
approved these changes
Oct 11, 2025
Landed in 1986ee4 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the error message on
vm.SourceTextModule
link errors.Fixes: #60157