Skip to content

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Oct 10, 2025

Improves the error message on vm.SourceTextModule link errors.

Fixes: #60157

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 10, 2025
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (e105e82) to head (43d6b6b).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/module_wrap.cc 66.66% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60199   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         704      704           
  Lines      208087   208085    -2     
  Branches    40006    40004    -2     
=======================================
+ Hits       184223   184224    +1     
- Misses      15869    15871    +2     
+ Partials     7995     7990    -5     
Files with missing lines Coverage Δ
src/module_wrap.h 52.94% <ø> (ø)
src/node_errors.h 86.48% <100.00%> (-0.70%) ⬇️
src/module_wrap.cc 75.27% <66.66%> (-0.34%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1986ee4 into nodejs:main Oct 12, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1986ee4

@legendecas legendecas deleted the vm-error branch October 12, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VM Module linking unclear error message

6 participants