Skip to content

test: ensure assertions are reachable in test/client-proxy #60175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2025
Merged

test: ensure assertions are reachable in test/client-proxy #60175

merged 1 commit into from
Oct 12, 2025
+10 −10

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 9, 2025

Another follow up of #60125

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 9, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (e105e82) to head (aff6d5b).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60175      +/-   ##
==========================================
+ Coverage   88.53%   88.55%   +0.02%     
==========================================
  Files         704      704              
  Lines      208087   208087              
  Branches    40006    40005       -1     
==========================================
+ Hits       184223   184273      +50     
+ Misses      15869    15825      -44     
+ Partials     7995     7989       -6

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 force-pushed the must-call-mustCalls-client-proxy branch from a4ba32e to aff6d5b Compare October 10, 2025 20:15
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69670/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69674/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69699/

@atlowChemi atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit da9cd74 into nodejs:main Oct 12, 2025
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in da9cd74

@aduh95 aduh95 deleted the must-call-mustCalls-client-proxy branch October 12, 2025 20:47
@RafaelGSS RafaelGSS mentioned this pull request Oct 13, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @nodejs-github-bot @cjihrig @atlowChemi