src: fix usage of deprecated V8 API #60174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely `GetContinuationPreservedEmbedderData` and `SetContinuationPreservedEmbedderData` for their "V2" variants. Refs: v8/v8@da41db3
targos
added
dont-land-on-v20.x
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60174 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 704 704
Lines 208083 208083
Branches 40011 40010 -1
==========================================
- Hits 184257 184246 -11
- Misses 15847 15860 +13
+ Partials 7979 7977 -2
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Oct 9, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
approved these changes
Oct 9, 2025
This comment was marked as outdated.
This comment was marked as outdated.
santigimeno
approved these changes
Oct 9, 2025
richardlau
approved these changes
Oct 9, 2025
cjihrig
approved these changes
Oct 9, 2025
|
macOS failed on https://ci.nodejs.org/job/node-test-commit-osx/67253/nodes=macos15-x64/testReport/junit/(root)/parallel/test_without_async_context_frame/, so I'm not very confident with this now. |
FWIW that test has been flaky across 19 PRs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-10.md#jstest-failure |
This comment was marked as outdated.
This comment was marked as outdated.
targos
added
the
commit-queue
Flarna
approved these changes
Oct 10, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 367bcce |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely
GetContinuationPreservedEmbedderDataandSetContinuationPreservedEmbedderDatafor their "V2" variants.Refs: v8/v8@da41db3