Skip to content

src: ERR_ILLEGAL_CONSTRUCTOR thrown from c++ had the wrong constructor #58364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nektro
Copy link
Contributor

@nektro nektro commented May 16, 2025

this brings it into sync with the definition of this error in lib/internal/errors.js.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (a436f7b) to head (89c79b5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58364      +/-   ##
==========================================
- Coverage   90.24%   90.22%   -0.02%     
==========================================
  Files         633      633              
  Lines      186859   186859              
  Branches    36685    36685              
==========================================
- Hits       168622   168598      -24     
- Misses      11036    11044       +8     
- Partials     7201     7217      +16     
Files with missing lines Coverage Δ
src/node_errors.h 87.50% <ø> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this but keep in mind that changing the error type is semver-major

@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 17, 2025
@aduh95
Copy link
Contributor

aduh95 commented May 19, 2025

The commit message should start with a verb in infinitive form, e.g. src: make `ERR_ILLEGAL_CONSTRUCTOR` inherit `TypeError` .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants