-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
http2: add diagnostics channel 'http2.client.stream.close' #58329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RaisinTen:http2-add-diagnostics-channel-http2.client.stream.close
May 19, 2025
Merged
http2: add diagnostics channel 'http2.client.stream.close' #58329
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RaisinTen:http2-add-diagnostics-channel-http2.client.stream.close
May 19, 2025
+121
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58329 +/- ##
==========================================
- Coverage 90.25% 90.23% -0.02%
==========================================
Files 633 633
Lines 186870 186878 +8
Branches 36697 36688 -9
==========================================
- Hits 168654 168636 -18
- Misses 11032 11042 +10
- Partials 7184 7200 +16
🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 14, 2025
cola119
approved these changes
May 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
bjohansebas
approved these changes
May 15, 2025
Signed-off-by: Darshan Sen <[email protected]>
ec237dd
to
14a1700
Compare
This comment was marked as outdated.
This comment was marked as outdated.
RafaelGSS
approved these changes
May 18, 2025
Landed in 7c74205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
diagnostics_channel
Issues and PRs related to diagnostics channel
http2
Issues or PRs related to the http2 subsystem.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.