esm: Source Phase Imports for WebAssembly

[guybedford]

This implements the Stage 3 Source Phase Imports proposal for Node.js (with latest specification at tc39/ecma262#3492), based on the new V8 parser and module loading APIs for this feature.

Phases in the module pipeline represent the ability to load uninstantiated modules (and in future with import defer, unexecuted modules as well).

While we are still waiting for progression on https://github.com/tc39/proposal-esm-phase-imports for JS Source Phase objects, this implements only the WebAssembly source phase per the Wasm ESM Integration Phase 3 proposal (https://github.com/webassembly/esm-integration).

This PR adds support both for dynamic and static source phase syntax:

import source mod1 from './mod.wasm';
const mod2 = await import.source('./mod.wasm');

This allows obtaining a Wasm module through the ESM integration, without it being instantiated through the Node.js resolver, to permit custom instantiations:

import source mod from './mod.wasm';

const instance = await WebAssembly.instantiate(mod, imports);

The dynamic source phase support is a one-line TODO, which is pending #56842. When this lands the skipped tests have been tested against that branch to fully pass.

When a source phase representation for a module is not available, a new ERR_SOURCE_PHASE_NOT_DEFINED SyntaxError is thrown as per the standard.

The VM API is updated to take a string phase argument as its last argument, although the ability to define source phase representations for virtual modules is not currently supported, and left as a future integration point. Perhaps this will simplify with ESM Phase Imports in future as well allowing handles to modules outside of the VM graph.

Resolves #53178.

@nodejs/loaders

[nodejs-github-bot]

Review requested:

• @nodejs/loaders
• @nodejs/startup
• @nodejs/vm

[codecov]

Codecov Report

Attention: Patch coverage is 83.85965% with 46 lines in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (1a6bef2) to head (f18b561).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	59.52%	23 Missing and 11 partials ⚠️
lib/internal/modules/esm/loader.js	87.50%	3 Missing and 1 partial ⚠️
lib/internal/modules/esm/module_job.js	95.45%	4 Missing ⚠️
lib/internal/vm/module.js	85.71%	3 Missing ⚠️
lib/repl.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56919      +/-   ##
==========================================
- Coverage   90.26%   90.24%   -0.03%     
==========================================
  Files         630      630              
  Lines      184690   184891     +201     
  Branches    36142    36173      +31     
==========================================
+ Hits       166712   166854     +142     
- Misses      11021    11064      +43     
- Partials     6957     6973      +16     

Files with missing lines	Coverage Δ
lib/internal/modules/cjs/loader.js	98.26% <100.00%> (ø)
lib/internal/modules/esm/translators.js	91.51% <100.00%> (+0.06%)	⬆️
lib/internal/modules/esm/utils.js	98.91% <100.00%> (+0.01%)	⬆️
lib/internal/modules/run_main.js	97.60% <100.00%> (ø)
lib/internal/process/execution.js	94.79% <100.00%> (-0.16%)	⬇️
lib/internal/vm.js	100.00% <100.00%> (ø)
src/module_wrap.h	0.00% <ø> (ø)
src/node.cc	74.06% <100.00%> (+0.10%)	⬆️
src/node_errors.h	87.50% <100.00%> (+2.20%)	⬆️
lib/repl.js	94.90% <75.00%> (-0.05%)	⬇️
... and 4 more

... and 25 files with indirect coverage changes

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64999/

[sbc100]

I'm working on corresponding patch to emscripten to enable source phase imports: emscripten-core/emscripten#23175

As such, I would love to see this patch landed so we can start testing it!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65474/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65476/

[guybedford]

Landed in db4dcc0.