workers: refactor stdio to improve performance #56630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested review from
ShogunPanda,
jasnell,
addaleax,
anonrig and
ronag
nodejs-github-bot
added
needs-ci
Signed-off-by: Matteo Collina <[email protected]>
mcollina
force-pushed
the
worker_stdio_refactor
branch
from
159cd0d to
f0c9885
Compare
anonrig
approved these changes
Jan 16, 2025
ronag
approved these changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56630 +/- ##
==========================================
+ Coverage 89.19% 89.20% +0.01%
==========================================
Files 662 662
Lines 191762 191904 +142
Branches 36907 36931 +24
==========================================
+ Hits 171041 171192 +151
+ Misses 13572 13556 -16
- Partials 7149 7156 +7
|
ShogunPanda
approved these changes
Jan 17, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Jan 18, 2025
jasnell
added
the
author ready
mcollina
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d978610 |
aduh95
pushed a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #56630 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 30, 2025
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #56630 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I fixed #56428, I've found that we could do quite a bit of refactoring and simplifying the sdtio in workers and remove code that is not really necessary anymore.
This PR also changes from
mapandforEachto use basic array operations because those can be hot paths, and therefore we can actually avoid a bottleneck.