Skip to content

Update contributing documentation file #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2017
Merged

Update contributing documentation file #382

merged 2 commits into from
Jun 13, 2017

Conversation

LaurentGoderre
Copy link
Member

Added a section about dependencies since it's one of the most common contribution.

@LaurentGoderre
Copy link
Member Author

If this gets merged, we should add a standard response here pointing to the dependency section a a standard answer for PR like #381

chorrell

This comment was marked as off-topic.

Sign in to view

chorrell

This comment was marked as off-topic.

Sign in to view

@LaurentGoderre
Copy link
Member Author

@Starefossen @hmalphettes @jlmitch5 @pesho @retrohacker your feedback would be most welcomed!

@LaurentGoderre
Copy link
Member Author

Sort of resolves #190

@Starefossen
Copy link
Member

LGTM, thanks @LaurentGoderre 👍

@pesho
Copy link
Contributor

pesho commented May 3, 2017

LGTM, but the mentioned "list of common dependencies" should probably exist somewhere prior to merging. Or it should be started as part of the PR.

@pesho pesho mentioned this pull request May 3, 2017
Merged
@chorrell
Copy link
Contributor

chorrell commented May 3, 2017

LGTM

@LaurentGoderre
Copy link
Member Author

@pesho any idea where would be the best place for it? A seperate .md file?

@pesho
Copy link
Contributor

pesho commented May 3, 2017

@LaurentGoderre I think README.md is fine too.

@pesho pesho mentioned this pull request May 29, 2017
Closed
Starefossen

This comment was marked as off-topic.

Sign in to view

retrohacker

This comment was marked as off-topic.

Sign in to view

@LaurentGoderre
Add a contributing documentation file
1ca17ba 
Added a section about dependencies since it's one of the most common contribution.
@LaurentGoderre
Copy link
Member Author

@retrohacker done!

@retrohacker
Copy link
Contributor

retrohacker commented Jun 2, 2017 •
edited
Loading

@LaurentGoderre looks like the sentence with the TODO is still there. Could we move that to an issue?

We can add the reference to a list of dependencies back into the CONTRIBUTING.md file as soon as the list exists :-)

@pesho
Copy link
Contributor

pesho commented Jun 4, 2017

@LaurentGoderre can you please rebase this now that #393 has been merged.

I also think that the sentence with the TODO should be removed before merging.

@LaurentGoderre
Copy link
Member Author

Done!

@pesho pesho self-requested a review June 5, 2017 12:52
pesho

This comment was marked as off-topic.

Sign in to view

@pesho pesho requested a review from retrohacker June 7, 2017 00:26
@pesho pesho changed the title Add a contributing documentation file Update contributing documentation file Jun 7, 2017
@retrohacker
Copy link
Contributor

LGTM as well 👍 :-)

@retrohacker
Copy link
Contributor

Merging w/ failing build as this is just documentation

retrohacker

This comment was marked as off-topic.

Sign in to view

@retrohacker retrohacker merged commit 720debf into nodejs:master Jun 13, 2017
@LaurentGoderre LaurentGoderre deleted the add-contributing branch June 13, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chorrell chorrell chorrell left review comments

@pesho pesho pesho approved these changes

@Starefossen Starefossen Starefossen approved these changes

@retrohacker retrohacker retrohacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LaurentGoderre @Starefossen @pesho @chorrell @retrohacker