-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Introduce Dockerfiles for nanoserver #223
Proposal: Introduce Dockerfiles for nanoserver #223
Conversation
It's worth noting that we (the official images team) don't have a reliable
way to build nanoserver images yet, so I'd recommend holding off on this
one.
|
ebdf10a
to
9ccbeb6
Compare
Updated this PR to latest versions Node.js 4.6 and 6.7. Introduced |
The recent failure looks like an issue with the test. The I opened #239 to improve the test script and once that lands you should probably rebase and try again. |
Although, ^ being said, I don't think the test build will ultimately run successfully since I don't think Travis-Ci has the necessary Windows/Docker support. I see you have a |
9ccbeb6
to
51f0384
Compare
70603f6
to
492bdab
Compare
Updated to Node.js 4.7.0, 6.9.2 and 7.2.1 :-) |
Signed-off-by: Stefan Scherer <[email protected]>
492bdab
to
e9444cf
Compare
Closing, see #362 for a more up to date PR with appveyor.yml |
As mentioned in #222 here is a proposal to build Windows Docker images with Node.js 4.7.0, 6.9.2 and 7.2.1 based on the Windows
nanoserver
base image.This allows Windows 10 1607 and Server 2016 users build and run Node.js in a Docker container.
The
test-build.ps1
can be called to build the images, either on a Windows 10 machine or a Windows Server 2016 machine. It downloads the ZIP files for Node.js 4.7.0, 6.9.2 and 7.2.1 and builds these Docker images:For information about how to get Docker running on Windows, please see the relevant "Quick Start" guide provided by Microsoft:
or use Docker for Windows Beta 26++ to try this PR.
Notes:
Usingcurl
orwget
in PowerShell in NanoServer is far from easy. The only working example I used for this Dockerfiles is from nanoserver/golang in the Microsoft/Virtualization-Documentation repo.Further thoughts about size:
My previous work which just does a COPY deployment of Node.js into a nanoserver container image and results in smaller Docker images than running the PowerShell script downloading the ZIP etc.