ansible: mirror _resha.sh changes #3837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra output from the `aws` commands is causing issues with the `release.sh` script from nodejs/node (which expects the only output to be the path to the `SHASUMS256.txt` file).
targos
approved these changes
Jul 17, 2024
targos
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra output from the
awscommands is causing issues with therelease.shscript from nodejs/node (which expects the only output to be the path to theSHASUMS256.txtfile).This is just a mirror of the current
_resha.shthat is on the server after @targos @RafaelGSS and I live debugged this while trying to release Node.js 22.5.0.The current
tools/release.shis capturing the output of the sign command (dist-sign->resha_release.sh->_resha.sh) and was getting confused by the extra output from theawscommands.Redirecting to
/dev/nullis going to make debugging issues with the r2 upload tricky, but for now this PR is keeping the repository in sync with what is live on the server.