Add implicit C14N when signing if no transforms specified #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When signing, the library currently does not apply any canonicalization to the referenced document being signed, unless explicitly specified in the
transformsconfig property.This behaviour differs from many other XML signature libraries such as javax.xml.crypto.dsig and signxml, who implicitly apply
http://www.w3.org/TR/2001/REC-xml-c14n-20010315if the user does not specify any canonicalization transforms.This PR proposes adding the same implicit canonicalization behaviour, to make the output more consistent with other implementations.
Related issues: #210 #212 #484 #486