fix(control-center/calendar): use nominative case for month's name - #3704
Draft
MaksRawski wants to merge 2 commits into
Draft
fix(control-center/calendar): use nominative case for month's name#3704MaksRawski wants to merge 2 commits into
MaksRawski wants to merge 2 commits into
Conversation
by default %B uses genitive, which doesn't make sense for standalone month name
Collaborator
|
Since Noctalia supports non-glibc builds, could we use %OB under I don't believe we need to check for older GLIBC versions. |
ItsLemmy
marked this pull request as draft
July 30, 2026 01:21
Author
|
Oh ok, I quickly skimmed through |
MaksRawski
force-pushed
the
fix-calendar-nominative
branch
from
July 30, 2026 18:07
fbc25ba to
e7f038a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use nominative instead of genitive case for month name displayed in the calendar tab of the control center.
Motivation
Month name that isn't used as part of further date formatting with a day should be written in nominative, and
%Buses genitive.With English locale this is not a problem, but it's as if it was written "of July 2026" instead of just "July 2026".
Type of Change
Testing
just testpasses. Manually verified.Manual Coverage
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes
std::strftimedoesn't have anOBspecifier even though C23'sstrftimehas. Since the standard doesn't mention it, it technically may not be available, however I assume that any implementation of C++'sstd::strftimejust calls C'sstrftimeand since noctalia depends on GLIBC anyway, I further assume that GLIBC is going to be used for that and%OBhas been in GLIBC since 2.27 (released in 2018).Maybe an additional check for a GLIBC version should be done in the build system?