feat(widgets/sysmon): add an option to hide the icon - #3665
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Sysmon widget setting to optionally hide the icon, enabling a more minimal “gauge-only” style and adjusting layout sizing when the icon is not shown.
Changes:
- Added a
show_iconwidget setting for Sysmon and made icon-related settings conditionally visible. - Threaded the new option through the widget factory into
SysmonWidgetoptions/state. - Updated Sysmon layout logic to avoid reserving icon space and to lengthen the gauge/graph when the icon is hidden.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/shell/settings/widget_settings_registry.cpp | Adds show_icon and updates settings visibility rules for Sysmon. |
| src/shell/bar/widgets/sysmon_widget.h | Adds showIcon option and stores m_showIcon in the widget. |
| src/shell/bar/widgets/sysmon_widget.cpp | Skips creating/placing the icon node when disabled and adjusts layout sizing accordingly. |
| src/shell/bar/widget_factory.cpp | Reads show_icon from widget config and passes it into SysmonWidgetOptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This allows a "minimal" style where only a gauge is displayed.
jinliu
force-pushed
the
feature/sysmon-no-icon
branch
from
July 28, 2026 04:20
00e7314 to
dc1e81a
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a "Show Icon" option to sysmon's settings. When off, the icon is hidden, and the gauge is made slightly longer because it doesn't need to match the icon.
Motivation
This allows a "minimal" style where only a gauge is displayed:

Type of Change
Manual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.