Skip to content

feat(widgets/sysmon): add an option to hide the icon - #3665

Merged
ItsLemmy merged 4 commits into
noctalia-dev:mainfrom
jinliu:feature/sysmon-no-icon
Jul 30, 2026
Merged

feat(widgets/sysmon): add an option to hide the icon#3665
ItsLemmy merged 4 commits into
noctalia-dev:mainfrom
jinliu:feature/sysmon-no-icon

Conversation

@jinliu

@jinliu jinliu commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Added a "Show Icon" option to sysmon's settings. When off, the icon is hidden, and the gauge is made slightly longer because it doesn't need to match the icon.

Motivation

This allows a "minimal" style where only a gauge is displayed:
screenshot_20260727_174005-region

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging

Manual Coverage

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Tested with different bar positions and density settings
  • Tested at different interface scaling values
  • Tested with multiple monitors

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format with clang-format v22+ installed, or this PR has no code changes.
  • I ran the relevant build or test commands, or explained why they were not run.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I will update end-user documentation after merge, or this PR does not change user-facing configuration or behavior.
  • I added or updated assets/translations/en.json, or this PR adds no new user-facing strings.
  • I did not edit non-English translation files unless this PR is explicitly for translation tooling, an import/export sync, or a maintainer-requested locale change.
  • I used the existing canonical names for config keys, IPC names, paths, and identifiers.

Copilot AI review requested due to automatic review settings July 27, 2026 09:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Sysmon widget setting to optionally hide the icon, enabling a more minimal “gauge-only” style and adjusting layout sizing when the icon is not shown.

Changes:

  • Added a show_icon widget setting for Sysmon and made icon-related settings conditionally visible.
  • Threaded the new option through the widget factory into SysmonWidget options/state.
  • Updated Sysmon layout logic to avoid reserving icon space and to lengthen the gauge/graph when the icon is hidden.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/shell/settings/widget_settings_registry.cpp Adds show_icon and updates settings visibility rules for Sysmon.
src/shell/bar/widgets/sysmon_widget.h Adds showIcon option and stores m_showIcon in the widget.
src/shell/bar/widgets/sysmon_widget.cpp Skips creating/placing the icon node when disabled and adjusts layout sizing accordingly.
src/shell/bar/widget_factory.cpp Reads show_icon from widget config and passes it into SysmonWidgetOptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/shell/bar/widgets/sysmon_widget.cpp Outdated
Comment thread src/shell/settings/widget_settings_registry.cpp Outdated
This allows a "minimal" style where only a gauge is displayed.
@jinliu
jinliu force-pushed the feature/sysmon-no-icon branch from 00e7314 to dc1e81a Compare July 28, 2026 04:20
@ItsLemmy

Copy link
Copy Markdown
Collaborator

Thanks!

@ItsLemmy
ItsLemmy merged commit 0e62670 into noctalia-dev:main Jul 30, 2026
2 checks passed
@jinliu
jinliu deleted the feature/sysmon-no-icon branch July 31, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants