Skip to content

Fix ml service memory leak #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
myungjoo wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix ml service memory leak #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions daemon/mlops-agent-node.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ _mlops_node_get (const int64_t id)
mlops_node_s *node = NULL;

G_LOCK (mlops_node_table);
node = (mlops_node_s *) g_hash_table_lookup (g_mlops_node_table,
GINT_TO_POINTER (id));
node = (mlops_node_s *) g_hash_table_lookup (g_mlops_node_table, &id);
G_UNLOCK (mlops_node_table);

if (!node) {
Expand Down Expand Up @@ -121,8 +120,8 @@ mlops_node_initialize (void)
{
G_LOCK (mlops_node_table);
if (!g_mlops_node_table) {
g_mlops_node_table = g_hash_table_new_full (g_direct_hash, g_direct_equal,
NULL, _mlops_node_free);
g_mlops_node_table = g_hash_table_new_full (g_int64_hash, g_int64_equal,
g_free, _mlops_node_free);
}
g_assert (g_mlops_node_table != NULL);
G_UNLOCK (mlops_node_table);
Expand Down Expand Up @@ -150,6 +149,7 @@ mlops_node_create (const gchar * name, const mlops_node_type_e type,
{
mlops_node_s *node = NULL;
gint result = -EIO;
gint64 *node_id = NULL;
gchar *desc = NULL;
GstElement *pipeline = NULL;
GError *err = NULL;
Expand Down Expand Up @@ -200,8 +200,11 @@ mlops_node_create (const gchar * name, const mlops_node_type_e type,
node->description = g_strdup (desc);
g_mutex_init (&node->lock);

node_id = g_new (gint64, 1);
*node_id = node->id;

G_LOCK (mlops_node_table);
g_hash_table_insert (g_mlops_node_table, GINT_TO_POINTER (node->id), node);
g_hash_table_insert (g_mlops_node_table, node_id, node);
G_UNLOCK (mlops_node_table);

*id = node->id;
Expand Down Expand Up @@ -251,7 +254,7 @@ mlops_node_destroy (const int64_t id)
node = _mlops_node_get (id);
if (node) {
G_LOCK (mlops_node_table);
g_hash_table_remove (g_mlops_node_table, GINT_TO_POINTER (id));
g_hash_table_remove (g_mlops_node_table, &id);
G_UNLOCK (mlops_node_table);
}

Expand Down