Closed
Conversation
songgot
requested review from
again4you,
anyj0527,
gichan-jang,
jaeyun-jung,
jijoongmoon,
myungjoo,
niley7464,
wooksong and
yeonykim2
as code owners
songgot
force-pushed
the
sqliteX
branch
2 times, most recently
from
3c35d4f to
6d787f1
Compare
Member
|
sql prebuilt libs are only needed for Android, so how about uploading them to android-resource repo? |
Add sqlite lib and header file Modify mk Signed-off-by: hyunil park <hyunil46.park@samsung.com>
Contributor
Author
|
Contributor
|
I just request adding sqlite library into android-res repo :) |
myungjoo
reviewed
Jan 22, 2025
| #include "mlops-agent-interface.h" | ||
| #include "mlops-agent-internal.h" | ||
| #include "../libsqliteX/include/sqlite3.h" | ||
| #include "../libsqliteX/include/sqlite3ext.h" |
Member
There was a problem hiding this comment.
sqlite is an external package.
use #include <headername.h> and add includepath to the script (.mk file). this will help moving sqlite to another repo.
Contributor
|
We don't need extern pkg in mlops-agent repo, now android library uses preconfigured library from gst. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sqlite lib and modify .mk