-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize golang dependencies like controller-runtime and k8s #1288
base: main
Are you sure you want to change the base?
Conversation
a3f01cb
to
badbab4
Compare
/retest |
3515ab2
to
ca49ffa
Compare
ca49ffa
to
2c1d743
Compare
8318f73
to
6e6eb02
Compare
6e6eb02
to
083f388
Compare
/retest |
1b3a5f3
to
4a60a15
Compare
4a60a15
to
71c8632
Compare
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
71c8632
to
98ada61
Compare
/test pull-kubernetes-nmstate-e2e-handler-k8s Some tests failed with an incorrect result |
Signed-off-by: Enrique Llorente <[email protected]>
98ada61
to
ca88f7e
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@qinqon: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Somehow is not able to configure back the initial network state
Looks like eth1 and eth2 initially are now down, but our test reset logic set them up, so there is a mismatch between initial state and final state between tests. |
Is this a BUG FIX or a FEATURE ?:
/kind enhancement
What this PR does / why we need it:
The golang dependencies are quite old and at unmaintained versions, this change bumps the bigs ones like controller-runtime and k8s to the new ones.