Skip to content

Commit

Permalink
Activate k8s reporter for handler e2e test (#647)
Browse files Browse the repository at this point in the history
The kubernetes e2e test reporter was activated for operator tests but
not for handler.

Signed-off-by: Quique Llorente <[email protected]>
  • Loading branch information
qinqon authored Nov 30, 2020
1 parent 765babc commit 2f18c09
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/e2e/handler/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (

corev1 "k8s.io/api/core/v1"

//knmstatereporter "github.com/nmstate/kubernetes-nmstate/test/reporter"
knmstatereporter "github.com/nmstate/kubernetes-nmstate/test/reporter"
"sigs.k8s.io/controller-runtime/pkg/client"
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
Expand Down Expand Up @@ -68,7 +68,7 @@ func TestE2E(t *testing.T) {
RegisterFailHandler(Fail)

reporters := make([]Reporter, 0)
//reporters = append(reporters, knmstatereporter.New("test_logs/e2e/handler", testenv.OperatorNamespace, nodes))
reporters = append(reporters, knmstatereporter.New("test_logs/e2e/handler", testenv.OperatorNamespace, nodes))
if ginkgoreporters.Polarion.Run {
reporters = append(reporters, &ginkgoreporters.Polarion)
}
Expand Down
8 changes: 8 additions & 0 deletions test/reporter/reporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ func (r *KubernetesNMStateReporter) logDeviceStatus(testName string) {
func (r *KubernetesNMStateReporter) Cleanup() {
// clean up artifacts from previous run
if r.artifactsDir != "" {
_, err := os.Stat(r.artifactsDir)
if err != nil {
if os.IsNotExist(err) {
return
} else {
panic(err)
}
}
names, err := ioutil.ReadDir(r.artifactsDir)
if err != nil {
panic(err)
Expand Down

0 comments on commit 2f18c09

Please sign in to comment.