Rename createPresentationTokenContent#936
Merged
Milena-Czierlinski merged 3 commits intorelease/openid4vcfrom Jan 23, 2026
Merged
Rename createPresentationTokenContent#936Milena-Czierlinski merged 3 commits intorelease/openid4vcfrom
createPresentationTokenContent#936Milena-Czierlinski merged 3 commits intorelease/openid4vcfrom
Conversation
Magnus-Kuhn
reviewed
Jan 23, 2026
Contributor
Magnus-Kuhn
left a comment
Magnus-Kuhn
left a comment
There was a problem hiding this comment.
Those don't create actual tokens though. I'd be fine with something like createPresentationTokenContent or createPresentationForPresentationToken though - is that acceptable?
Member
Author
|
Alright, I'll change it to |
Milena-Czierlinski
changed the title
createPresentationToken consistentlycreatePresentationTokenContent
Magnus-Kuhn
approved these changes
Jan 23, 2026
Milena-Czierlinski
deleted the
consistent-naming-create-presentation-token
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist