Improve namings in the oid4vc use cases#861
Merged
Magnus-Kuhn merged 6 commits intorelease/openid4vcfrom Nov 21, 2025
Merged
Conversation
Magnus-Kuhn
changed the title
Magnus-Kuhn
requested review from
Milena-Czierlinski,
jkoenig134 and
tnotheis
tnotheis
reviewed
Nov 21, 2025
packages/runtime/src/extensibility/facades/consumption/OpenId4VcFacade.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/extensibility/facades/consumption/OpenId4VcFacade.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/useCases/consumption/openid4vc/AcceptCredentialOffer.ts
Show resolved
Hide resolved
packages/runtime-types/src/consumption/Oid4VpVerificationResultDTO.ts
Outdated
Show resolved
Hide resolved
packages/runtime-types/src/consumption/ResolvedAuthorizationRequestDTO.ts
Outdated
Show resolved
Hide resolved
packages/runtime-types/src/consumption/ResolvedCredentialOfferDTO.ts
Outdated
Show resolved
Hide resolved
tnotheis
reviewed
Nov 21, 2025
packages/runtime/src/useCases/consumption/openid4vc/AcceptAuthorizationRequest.ts
Outdated
Show resolved
Hide resolved
tnotheis
previously approved these changes
Nov 21, 2025
Magnus-Kuhn
dismissed stale reviews from tnotheis and Milena-Czierlinski
via
da75191
tnotheis
approved these changes
Nov 21, 2025
Milena-Czierlinski
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist