feat: add PaymentController v2 architecture#1
Open
foppe-nvv wants to merge 1 commit into
Open
Conversation
0spinboson
force-pushed
the
refactor/payment-controller-architecture
branch
3 times, most recently
from
e8e80ae to
9453739
Compare
Collaborator
|
cleaned up and reordered the code additions and changes into thematic commits now that everything seems to be working |
0spinboson
force-pushed
the
refactor/payment-controller-architecture
branch
6 times, most recently
from
f82df10 to
6263703
Compare
0spinboson
force-pushed
the
refactor/payment-controller-architecture
branch
from
6263703 to
9d33c09
Compare
0spinboson
changed the title
0spinboson
force-pushed
the
refactor/payment-controller-architecture
branch
from
9d33c09 to
15a8dfc
Compare
0spinboson
changed the title
Add a template-method based PaymentController that orchestrates the full payment lifecycle: initiate -> proceed -> process_response. - PaymentController base class with abstract gateway contracts - Payment Session Log DocType for tracking payment state - Payment Button DocType for gateway selection UI - /pay universal payment endpoint with multi-gateway support - Type system (TxData, Proceeded, Processed, SessionStates) - Custom exception hierarchy for structured error handling - TX data filtering whitelist to prevent parameter tampering - Concurrency guards with document locking and terminal state checks - is_v2_gateway() utility for detecting v2-compatible gateways - Fix delete_custom_fields to use composite key lookup - Fix get_checkout_url to route through get_payment_gateway_controller - Add Payment Session Log link field on Payment Request - Integration tests for controller lifecycle
0spinboson
force-pushed
the
refactor/payment-controller-architecture
branch
from
15a8dfc to
cdf1bbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal tracking PR. Upstream: frappe#192
Branches
refactor/payment-controller-architecturefeat/stripe-payment-intentfeat/stripe-e2e-and-ci