Fix infinite recursion in .copyEnv() on circular environment references#987
Merged
mattfidler merged 2 commits into985-renamefrom Feb 20, 2026
Merged
Fix infinite recursion in .copyEnv() on circular environment references#987mattfidler merged 2 commits into985-renamefrom
.copyEnv() on circular environment references#987mattfidler merged 2 commits into985-renamefrom
Conversation
Merged
Co-authored-by: mattfidler <514778+mattfidler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix deep copy issue in copy UI
Fix infinite recursion in Feb 20, 2026
.copyEnv() on circular environment references
mattfidler
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.copyEnv()had no protection against circular environment references, causing infinite recursion and stack overflow when an environment directly or indirectly referenced itself.Changes
.copyEnv(): Added avisitedhash environment parameter (defaulting to a fresh env) that maps each environment's address to its already-created copy. Before recursing, checksvisitedfor a cached copy and returns it immediately if found. Stores the new (empty) copy invisitedbefore populating it — critical for self-referential cases (e$self <- e)..copyUi(): Creates a single sharedvisitedmap and passes it to all.copyEnv()calls so shared environment references across UI items are tracked uniformly.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.