Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn about layer stacking strategies #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yajo
Copy link

@yajo yajo commented Apr 11, 2024

Layers won't stack if they're siblings. They'll only stack if they're parents.

It is better to be clear about this subject to avoid surprises.

@moduon MT-1075

@yajo yajo force-pushed the warn-layer-stacking branch from eaff1a6 to c5cdcb9 Compare April 19, 2024 08:48
@yajo
Copy link
Author

yajo commented Apr 19, 2024

All attended.

Layers won't stack if they're siblings. They'll only stack if they're parents.

It is better to be clear about this subject to avoid surprises.

@moduon MT-1075
@yajo yajo force-pushed the warn-layer-stacking branch from c5cdcb9 to e72ae50 Compare May 9, 2024 09:12
@yajo
Copy link
Author

yajo commented May 9, 2024

It wasn't obvious to me that a simple intermediate solution is folding layers. I added that to the docs.

Do you think this can be merged now? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants