feat: add an easy way to configure users and groups and /tmp #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewo
reviewed
Apr 13, 2024
There was a problem hiding this comment.
Nice job!
I'm wondering if we should create a kind of namespace for this kind of helpers.
Instead of nix2container.shadowLayer, I would suggest nix2container.layers.shadow.
Because, once we have nix2container.layers.shadow, i'm pretty sure we would like nix2container.layers.tmp to create /tmp.
What do you think?
Otherwise, this lgtm!
Just like nixpkgs provides `dockerTools.shadowSetup`, nix2container needs a quick way to configure users, groups and permissions within the container. Here it is. @moduon MT-1075
yajo
commented
Apr 19, 2024
yajo
commented
Apr 19, 2024
|
Would you please let workflows run? |
yajo
changed the title
|
Tests are failing, but I think it's because of a lower-level issue that changes permissions when some derivation is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like nixpkgs provides
dockerTools.shadowSetup, nix2container needs a quick way to configure users, groups and permissions within the container.Here it is.
@moduon MT-1075