Speed up skopeo copy
#125
Open
Speed up skopeo copy
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewo
reviewed
Mar 29, 2024
There was a problem hiding this comment.
I'm not sure it's a good idea to override the default Skopeo value. I think it's pretty hard to predict side effects of this new value (for instance, rate limiting on registries because of too many connection open).
It would actually be much better if Skopeo could provide an option allowing the user to set this value at runtime.
Is there a Skopeo issue about this?
If not, i think we should create one to see if such option could be added to Skopeo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images produced by
nix2containerusually contain more than 100 layers. It takes a long time to decide whether each layer should be skipped. This PR makes the process faster by increasing the concurrency to 64.