Add writeSkopeoApplication helper. #115
Merged
+27
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepurvis
force-pushed
the
add-writeSkopeoApplication
branch
from
7c3dfc0 to
760f826
Compare
|
Arf, as expected, the CI fails while it works locally. I don't run the tests with I will have to figure out what is happening but it's not related to this PR. So, let's merge it and fix the GitHub CI job later.
No, it's not a major cost. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #77 (comment); not really essential but might be a nice improvement.
Main thing to watch for is that now
jqis required for all the little scripts, but it is just a few hundred kb, so I don't think this is a major cost.